-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
correct onvif filters #622
correct onvif filters #622
Conversation
Signed-off-by: Johnson Shih <[email protected]>
Signed-off-by: Johnson Shih <[email protected]>
Signed-off-by: Johnson Shih <[email protected]>
Signed-off-by: Johnson Shih <[email protected]>
Signed-off-by: Johnson Shih <[email protected]>
Signed-off-by: Johnson Shih <[email protected]>
Signed-off-by: Johnson Shih <[email protected]>
Signed-off-by: Johnson Shih <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johnsonshih this seems like a fine change to ignore casing but i am not sure how this fixes #597 given how the issue as described is only number IP address filters. Can you update the PR description or create a new issue that discusses this new bug with letter casing?
Signed-off-by: Johnson Shih <[email protected]>
I had updated the PR description to explain why/what this change is. For filtering IP address using case-insensitive comparison, it doesn't have any impact when filter IPv4 addresses, but in case we add IPv6 support for onvif DH, we don't need to change the filter. |
What this PR does / why we need it:
This PR fixes the issue. #597
The issue was fixed by #604, but that change causes regression when filter scopes. This PR contains a correct fix for onvif scopes, ip and mac address filters:
Special notes for your reviewer:
If applicable:
cargo fmt
)cargo build
)cargo clippy
)cargo test
)cargo doc
)