helm: Generate a self-signed cert for webhook if none given #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diconico07
requested review from
bfjelds,
kate-goldenring,
jiria,
Britel,
romoh and
adithyaj
as code owners
jbpaux
reviewed
Apr 21, 2023
diconico07
force-pushed
the
autogen-webhook-certs
branch
from
8b37b86
to
931a4e5
Compare
kate-goldenring
approved these changes
May 10, 2023
Use the ingress-nginx/kube-webhook-certgen image to generate a self-signed certificate valid for 100 years for admission webhook when the caBundle is left unconfigured. Signed-off-by: Nicolas Belouin <[email protected]>
Signed-off-by: Nicolas Belouin <[email protected]>
diconico07
force-pushed
the
autogen-webhook-certs
branch
from
931a4e5
to
148762d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Use the ingress-nginx/kube-webhook-certgen image to generate a self-signed certificate valid for 100 years for admission webhook when the caBundle is left unconfigured in the chart values.
closes #569
Special notes for your reviewer:
If applicable:
cargo fmt)cargo build)cargo clippy)cargo test)cargo doc)