udev: Add devnode to mounts not devpath #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The udev discovery handler currently adds the udev devpath to the device mounts, this doesn't allow access to the devnode and moreover said devpath is not a correct absolute path (it is relative to `/sys`). This commit changes the current behavior to add the devnode (if any) to the device mounts instead of the (wrong) sysfs devpath. Signed-off-by: Nicolas Belouin <[email protected]>
diconico07
requested review from
bfjelds,
kate-goldenring,
jiria,
Britel,
romoh and
adithyaj
as code owners
|
@diconico07 great catch! This was caused by my changes here not keeping the mounting of the devnode consistent: #534. |
|
/version patch |
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kate-goldenring
approved these changes
Mar 2, 2023
|
I am not sure why e2e tests are not being kicked off |
From what I read in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The udev discovery handler currently adds the udev devpath to the device mounts, this doesn't allow access to the devnode and moreover said devpath is not a correct absolute path (it is relative to
/sys).This PR changes the current behavior to add the devnode (if any) to the device mounts instead of the (wrong) sysfs devpath.
Special notes for your reviewer:
If applicable:
cargo fmt)cargo build)cargo clippy)cargo test)cargo doc)