Set pre_start_required to false in get_device_plugin_options

[johnsonshih]

Signed-off-by: johnsonshih [email protected]

What this PR does / why we need it:
Set pre_start_required to false in get_device_plugin_options to match the setting in register().

We set pre_start_required to false when akri instance device plugin registers itself to kubelet but kubelet still calls get_device_plugin_options to decide if to call device plugin's pre_start_container() In get_device_plugin_options(), we return true for pre_start_required so kubelet calls pre_start_container(). We don't expect the pre_start_container() to be called so we dump an error message and return empty option. Since we don't want the pre_start_container() to be called, we should set pre_start_required to false in get_device_plugin_options().

Special notes for your reviewer:

If applicable:

• this PR has an associated PR with documentation in akri-docs
• this PR contains unit tests
• added code adheres to standard Rust formatting (cargo fmt)
• code builds properly (cargo build)
• code is free of common mistakes (cargo clippy)
• all Akri tests succeed (cargo test)
• inline documentation builds (cargo doc)
• all commits pass the DCO bot check by being signed off -- see the failing DCO check for instructions on how to retroactively sign commits

[kate-goldenring]

@johnsonshih can you provide some context on why this change is desired and the anticipated impact?

[johnsonshih]

@johnsonshih can you provide some context on why this change is desired and the anticipated impact?

We set pre_start_required to false when akri instance device plugin registers itself to kubelet but kubelet still calls get_device_plugin_options to decide if to call device plugin's pre_start_container() In get_device_plugin_options(), we return true for pre_start_required so kubelet calls pre_start_container(). We don't expect the pre_start_container() to be called so we dump an error message and return empty option. Since we don't want the pre_start_container() to be called, we should set pre_start_required to false in get_device_plugin_options().

The impact is an unnecessary error message shown the might cause confusion.

[johnsonshih]

/add-same-version-label

[github-actions]

👋 Added [same version] label :)!

[github-actions]

👋 Added [same version] label :)!