Make Discovery Handlers check channel health each discovery loop #385
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Akri's Discovery Handlers were designed to only send updates to the Agent if new devices are discovered. This means that if the Agent restarts, the Discovery Handler may not know to register with it again, since it is only aware of Agent restarts when a send errors. This creates scenarios where an operator may do a
helm upgrade
to modify a configuration, say to filter for certain ONVIF cameras and the change may not be communicated to the Discovery Handler due to the following: The Agent will see the Configuration has changed and close its connection with the discovery handler. The Discovery Handler will not know the connection is closed since devices have not gone offline, so it will not re-register and therefore receive the new filtering information.To fix this, the Discovery Handlers should check if the channel with the Agent is open at the beginning of each discovery loop. If not, it should re-register with the Agent.
Special notes for your reviewer:
If applicable:
cargo fmt
)cargo build
)cargo clippy
)cargo test
)cargo doc
)./version.sh
)