-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Akri Kubernetes and Runtime Dependencies #361
Update Akri Kubernetes and Runtime Dependencies #361
Conversation
there is sooo much code change in this PR ... thanks for sorting through all the ramifications of updating these! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the exception of locking the h2 version, the change looks good.
might not be for this PR, but when i run the tests on my work machine i get failures in test_timeout_for_simple_onvif_discover. it seems to be that i'm finding 4 cameras but get_responsive_uris is only returning for 2 of them, so simple_onvif_discover is taking longer than the expected time. maybe we should mock OnvifQuery in the test? |
Interesting. I tested it locally too using |
3574af8
to
b333e97
Compare
Out tarpaulin code coverage tests are failing with:
However, when I ran |
i think the test has lost its meaning a bit. previously, the intent was to see if the udp discovery stopped ~2 seconds when the timeout was set to 2. now, with the timeout set to 2 seconds, for me, the discovery takes ~3.1 seconds (but for you it takes less than 2.2 seconds). i can make the test pass if i change what in any case, maybe this is a test improvement that can be made later (or if tests fail for other people). |
increasing the tarpaulin version to the latest seems to have done the trick |
84a8e44
to
a4fba1d
Compare
… with git sources" This reverts commit 5365e22.
1fa7391
to
5be85eb
Compare
Signed-off-by: vincepnguyen <[email protected]>
What this PR does / why we need it:
This PR updates our major dependencies. Most importantly, it updates
tokio
to1.0
and to the latestkube-rs
andk8s-openapi
versions.Special notes for your reviewer:
udev
and any dependencies in the Webhook (See next points)kube-rs
andk8s-openapi
.It may be due to the need to possibly regenerate the Configuration OpenAPI API that @DazWilkin generated and hosts here. We could also switch to using theIt was due to tests expecting thekube-rs
Admission Controller type now that they support one. For now, the Webhook dependencies are left un-updated and point at theakri-shared
library from the latest release.metadata.generation
to be f64; however, the Kubernetes API defines it as an integer, since this field is incremented every time a CustomResource is modified.Updatesversion.sh
to not update or check the version Akri packages that have a git source (aka akri-shared in the Admission Controller).cargo clippy
warnings that had been hanging around. Some still are not fixed, such as functions with too many parametersudev
crate needs more work to updatecloses #223
The following will be closed once the Webhook dependencies are also updated.
closes #349
closes #358
closes #359
If applicable:
cargo fmt
)cargo build
)cargo clippy
)cargo test
)cargo doc
)./version.sh
)