Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove un-utilized CRD field #290

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion agent/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "agent"
version = "0.4.6"
version = "0.5.0"
authors = ["Kate Goldenring <[email protected]>", "<[email protected]>"]
edition = "2018"

Expand Down
1 change: 0 additions & 1 deletion agent/src/util/device_plugin_service.rs
Original file line number Diff line number Diff line change
Expand Up @@ -505,7 +505,6 @@ async fn try_create_instance(
nodes: vec![dps.node_name.clone()],
device_usage,
metadata: get_all_broker_properties(&dps.config.properties, &dps.device.properties),
rbac: "rbac".to_string(),
kate-goldenring marked this conversation as resolved.
Show resolved Hide resolved
};

// Try up to MAX_INSTANCE_UPDATE_TRIES to create or update instance, breaking on success
Expand Down
1 change: 0 additions & 1 deletion agent/src/util/slot_reconciliation.rs
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,6 @@ impl DevicePluginSlotReconciler {
let modified_instance = Instance {
configuration_name: instance.spec.configuration_name.clone(),
metadata: instance.spec.metadata.clone(),
rbac: instance.spec.rbac.clone(),
shared: instance.spec.shared,
device_usage: modified_device_usage,
nodes: instance.spec.nodes.clone(),
Expand Down
2 changes: 1 addition & 1 deletion controller/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "controller"
version = "0.4.6"
version = "0.5.0"
authors = ["<[email protected]>"]
edition = "2018"

Expand Down
1 change: 0 additions & 1 deletion controller/src/util/node_watcher.rs
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,6 @@ impl NodeWatcher {
let modified_instance = Instance {
configuration_name: instance.spec.configuration_name.clone(),
metadata: instance.spec.metadata.clone(),
rbac: instance.spec.rbac.clone(),
shared: instance.spec.shared,
device_usage: modified_device_usage,
nodes: modified_nodes,
Expand Down
4 changes: 2 additions & 2 deletions deployment/helm/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.4.6
version: 0.5.0

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
appVersion: 0.4.6
appVersion: 0.5.0
2 changes: 0 additions & 2 deletions deployment/helm/crds/akri-instance-crd.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@ spec:
additionalProperties:
type: string
type: object
rbac:
kate-goldenring marked this conversation as resolved.
Show resolved Hide resolved
type: string
additionalPrinterColumns:
- name: Config
type: string
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "debug-echo-discovery-handler"
version = "0.4.6"
version = "0.5.0"
authors = ["Kate Goldenring <[email protected]>"]
edition = "2018"

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "onvif-discovery-handler"
version = "0.4.6"
version = "0.5.0"
authors = ["Kate Goldenring <[email protected]>"]
edition = "2018"

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "opcua-discovery-handler"
version = "0.4.6"
version = "0.5.0"
authors = ["Kate Goldenring <[email protected]>"]
edition = "2018"

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "udev-discovery-handler"
version = "0.4.6"
version = "0.5.0"
authors = ["Kate Goldenring <[email protected]>"]
edition = "2018"

Expand Down
2 changes: 1 addition & 1 deletion discovery-handlers/debug-echo/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "akri-debug-echo"
version = "0.4.6"
version = "0.5.0"
authors = ["Kate Goldenring <[email protected]>"]
edition = "2018"

Expand Down
2 changes: 1 addition & 1 deletion discovery-handlers/onvif/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "akri-onvif"
version = "0.4.6"
version = "0.5.0"
authors = ["Kate Goldenring <[email protected]>"]
edition = "2018"

Expand Down
2 changes: 1 addition & 1 deletion discovery-handlers/opcua/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "akri-opcua"
version = "0.4.6"
version = "0.5.0"
authors = ["Kate Goldenring <[email protected]>"]
edition = "2018"

Expand Down
2 changes: 1 addition & 1 deletion discovery-handlers/udev/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "akri-udev"
version = "0.4.6"
version = "0.5.0"
authors = ["Kate Goldenring <[email protected]>"]
edition = "2018"

Expand Down
2 changes: 1 addition & 1 deletion discovery-utils/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "akri-discovery-utils"
version = "0.4.6"
version = "0.5.0"
authors = ["Kate Goldenring <[email protected]>"]
edition = "2018"

Expand Down
1 change: 0 additions & 1 deletion samples/brokers/onvif-video-broker/Akri.cs
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ public class Instance
public bool Shared { get; set; }
public IList<String> Nodes { get; set; }
public Dictionary<String, String> DeviceUsage { get; set; }
public string Rbac { get; set; }
}

public static class Akri
Expand Down
2 changes: 1 addition & 1 deletion samples/brokers/udev-video-broker/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "udev-video-broker"
version = "0.4.6"
version = "0.5.0"
authors = ["Kate Goldenring <[email protected]>", "<[email protected]>"]
edition = "2018"

Expand Down
2 changes: 1 addition & 1 deletion shared/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "akri-shared"
version = "0.4.6"
version = "0.5.0"
authors = ["<[email protected]>"]
edition = "2018"

Expand Down
18 changes: 3 additions & 15 deletions shared/src/akri/instance.rs
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,6 @@ pub struct Instance {
/// the slot)
#[serde(default)]
pub device_usage: HashMap<String, String>,

/// This is a placeholder for eventual RBAC support
#[serde(default = "default_rbac")]
pub rbac: String,
}

/// Get Instances for a given namespace
Expand Down Expand Up @@ -175,8 +171,7 @@ pub async fn find_instance(
/// shared: true,
/// nodes: Vec::new(),
/// device_usage: std::collections::HashMap::new(),
/// metadata: std::collections::HashMap::new(),
/// rbac: "".to_string(),
/// metadata: std::collections::HashMap::new()
/// },
/// "instance-1",
/// "default",
Expand Down Expand Up @@ -322,7 +317,6 @@ pub async fn delete_instance(
/// nodes: Vec::new(),
/// device_usage: std::collections::HashMap::new(),
/// metadata: std::collections::HashMap::new(),
/// rbac: "".to_string(),
/// },
/// "instance-1",
/// "default",
Expand Down Expand Up @@ -382,9 +376,6 @@ pub async fn update_instance(
fn default_shared() -> bool {
false
}
fn default_rbac() -> String {
"".to_string()
}

#[cfg(test)]
mod crd_serializeation_tests {
Expand Down Expand Up @@ -421,10 +412,9 @@ mod crd_serializeation_tests {
assert_eq!(default_shared(), deserialized.shared);
assert_eq!(0, deserialized.nodes.len());
assert_eq!(0, deserialized.device_usage.len());
assert_eq!(0, deserialized.rbac.len());

let serialized = serde_json::to_string(&deserialized).unwrap();
let expected_deserialized = r#"{"configurationName":"foo","metadata":{},"shared":false,"nodes":[],"deviceUsage":{},"rbac":""}"#;
let expected_deserialized = r#"{"configurationName":"foo","metadata":{},"shared":false,"nodes":[],"deviceUsage":{}}"#;
assert_eq!(expected_deserialized, serialized);
}

Expand All @@ -441,10 +431,9 @@ mod crd_serializeation_tests {
assert_eq!(default_shared(), deserialized.shared);
assert_eq!(0, deserialized.nodes.len());
assert_eq!(0, deserialized.device_usage.len());
assert_eq!(0, deserialized.rbac.len());

let serialized = serde_json::to_string(&deserialized).unwrap();
let expected_deserialized = r#"{"configurationName":"foo","metadata":{},"shared":false,"nodes":[],"deviceUsage":{},"rbac":""}"#;
let expected_deserialized = r#"{"configurationName":"foo","metadata":{},"shared":false,"nodes":[],"deviceUsage":{}}"#;
assert_eq!(expected_deserialized, serialized);
}

Expand All @@ -459,7 +448,6 @@ mod crd_serializeation_tests {
assert_eq!(true, deserialized.shared);
assert_eq!(2, deserialized.nodes.len());
assert_eq!(2, deserialized.device_usage.len());
assert_eq!(0, deserialized.rbac.len());

let _ = serde_json::to_string(&deserialized).unwrap();
}
Expand Down
2 changes: 0 additions & 2 deletions shared/src/k8s/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -534,7 +534,6 @@ impl KubeInterface for KubeImpl {
/// nodes: Vec::new(),
/// device_usage: std::collections::HashMap::new(),
/// metadata: std::collections::HashMap::new(),
/// rbac: "".to_string(),
/// },
/// "instance-1",
/// "instance-namespace",
Expand Down Expand Up @@ -604,7 +603,6 @@ impl KubeInterface for KubeImpl {
/// nodes: Vec::new(),
/// device_usage: std::collections::HashMap::new(),
/// metadata: std::collections::HashMap::new(),
/// rbac: "".to_string(),
/// },
/// "instance-1",
/// "instance-namespace"
Expand Down
2 changes: 1 addition & 1 deletion version.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.4.6
0.5.0
2 changes: 1 addition & 1 deletion webhooks/validating/configuration/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "webhook-configuration"
version = "0.4.6"
version = "0.5.0"
authors = ["DazWilkin <[email protected]>"]
edition = "2018"

Expand Down