Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get Agent logs before testing their contents [SAME VERSION] #197

Merged
merged 4 commits into from
Jan 12, 2021
Merged

Get Agent logs before testing their contents [SAME VERSION] #197

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6e39fc3
add additional checks to see why getting logs failing
kate-goldenring Jan 11, 2021
a5c510d
log information when get crictl error
kate-goldenring Jan 11, 2021
b0b2b07
use os.system to log info
kate-goldenring Jan 11, 2021
6a53380
try using shell with subprocess when doing complex commands
kate-goldenring Jan 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions test/run-end-to-end.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/env python3
import shared_test_code
import json, os, time, yaml
import json, os, subprocess, time, yaml
from kubernetes import client, config
from kubernetes.client.rest import ApiException

Expand Down Expand Up @@ -105,9 +105,21 @@ def do_test():
# Check that slot reconciliation is working on agent
#
print("Check logs for Agent slot-reconciliation for pod {}".format(shared_test_code.agent_pod_name))
result = os.system('sudo {} logs {} | grep "get_node_slots - crictl called successfully" | wc -l | grep -v 0'.format(kubectl_cmd, shared_test_code.agent_pod_name))
if result != 0:
print("Akri failed to successfully connect to crictl via the CRI socket")
temporary_agent_log_path = "/tmp/agent_log.txt"
for x in range(3):
log_result = subprocess.run('sudo {} logs {} > {}'.format(kubectl_cmd, shared_test_code.agent_pod_name, temporary_agent_log_path), shell=True)
if log_result.returncode == 0:
print("Successfully stored Agent logs in {}".format(temporary_agent_log_path))
break
print("Failed to get logs from {} pod with result {} on attempt {} of 3".format(shared_test_code.agent_pod_name, log_result, x))
if x == 2:
return False
grep_result = subprocess.run('grep "get_node_slots - crictl called successfully" {} | wc -l | grep -v 0'.format(temporary_agent_log_path), shell=True)
if grep_result.returncode != 0:
print("Akri failed to successfully connect to crictl via the CRI socket with return value of {}", grep_result)
# Log information to understand why error occurred
os.system('sudo {} get pods,services,akric,akrii --show-labels'.format(kubectl_cmd))
os.system('grep get_node_slots {}'.format(temporary_agent_log_path))
return False

#
Expand Down Expand Up @@ -141,7 +153,7 @@ def do_test():
restored_brokers_info = shared_test_code.get_running_pod_names_and_uids(broker_pod_selector)
if len(restored_brokers_info) != 2:
print("Expected to find 2 broker pods but found: {}", len(restored_brokers_info))
os.system('sudo {} get pods,services,akric,akrii --show-labels'.foramt(kubectl_cmd))
os.system('sudo {} get pods,services,akric,akrii --show-labels'.format(kubectl_cmd))
return False

# Make sure that the deleted broker uid is different from the restored broker pod uid ... signifying
Expand Down