Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Viz #15

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Add Viz #15

merged 1 commit into from
Jul 18, 2022

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Jul 18, 2022

No description provided.

@programatik29 programatik29 merged commit ac5f522 into programatik29:master Jul 18, 2022
@programatik29
Copy link
Owner

@fundon viz 0.2.0 doesn't compile.

@fundon
Copy link
Contributor Author

fundon commented Jul 18, 2022

I tested in stable & latest nightly.

If your nightly version is less than 2022-07-16, update it. The issue is rust-lang/rust#99343.

# stable
rustc 1.62.0 (a8314ef7d 2022-06-27)
binary: rustc
commit-hash: a8314ef7d0ec7b75c336af2c9857bfaf43002bfc
commit-date: 2022-06-27
host: x86_64-apple-darwin
release: 1.62.0
LLVM version: 14.0.5
# nightly
rustc 1.64.0-nightly (d5e7f4782 2022-07-16)
binary: rustc
commit-hash: d5e7f4782e4b699728d0a08200ecd1a54d56a85d
commit-date: 2022-07-16
host: x86_64-apple-darwin
release: 1.64.0-nightly
LLVM version: 14.0.6

@programatik29
Copy link
Owner

I updated it. Still doesn't compile.
Error message:

error[E0432]: unresolved imports `http_body::LengthLimitError`, `http_body::Limited`
 --> .../viz-core-0.2.0/src/request.rs:3:17
  |
3 | use http_body::{LengthLimitError, Limited};
  |                 ^^^^^^^^^^^^^^^^  ^^^^^^^ no `Limited` in the root
  |                 |
  |                 no `LengthLimitError` in the root

@programatik29
Copy link
Owner

I think the problem is viz-core depends on http-body 0.4 but it actually depends on http-body 0.4.5. I did cargo update which fixed this but there is definitely a problem.

@fundon
Copy link
Contributor Author

fundon commented Jul 18, 2022

Yes, I checked the http-body, LengthLimitError, Limited was added in 0.4.5.

I should lock the version.

@programatik29
Copy link
Owner

Found some more problems in viz.

You should run this command: cargo hack check --each-feature --no-dev-deps.

Install cargo hack by cargo install cargo-hack if you haven't already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants