-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moves tl:dr to bottom of the channel #3
base: master
Are you sure you want to change the base?
Conversation
Do we need to put that |
Fair enough, should #information start with rules then? |
I guess so, yeah. |
Alright, modified accordingly. |
Wait, I misinterpreted what you said, my bad 😅 I don't think we should get rid of that top "welcome" part. Those links should probably stay in there. |
Yes we need the "Updated On" in there because Discord collapses timestamps and you'd have to scroll all the way up the channel to check the date. |
Not sure why this info is important, but the way it was done before, it was include in the top embed's footer, so you needed to scroll all the way to the top too. |
Having to scroll all the way up was bad, so I opened the issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been dead for a bit, but it looks good to me 👌
@@ -112,12 +112,6 @@ client.on('ready', async () => { | |||
embed.setAuthor(title, guild.iconURL, `https://progdisc.club/rules/#${mdFragment}`); | |||
} | |||
|
|||
if (i === 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we should revert this and change it so that it modifies the last embed instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, maybe add a link to this repo's commit log as a changelog of sorts.
This currently needs reviewing. I have moved tl:dr to the bottom of the markdown, however the automated script depends on the first segment to put "Updated on" text and https://progdisc.club url on the title and it overrides the title text with "Programming Discussions", if Rules section is to stay at top, the "Updated on" text would stay between the first and second embed as Rules section is too large for a single embed, or we can modify the script to not do any of these things as an alternative.