Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate py versions #246

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Deprecate py versions #246

merged 3 commits into from
Sep 10, 2024

Conversation

barbieri
Copy link
Member

Python 3.7 life ended on 2023-06-27

take the time to update deps, poetry lock and fix issues that were reported.

@barbieri barbieri self-assigned this Sep 10, 2024
bump minimum python version to 3.8 since 3.7 was EoL on June 27th 2023.

also bump deps, including flake8 and others, which caused some new issues
that were fixed:
 - dict.fromkeys() instead of dict comprehensions (C420)
 - repr sgqlc.operation.__init__.Selector is now sgqlc.operation.Selector
 - sgqlc.operation doctest was polluting sgqlc.types, save a snapshot
   and restore it so it always works
@coveralls
Copy link

coveralls commented Sep 10, 2024

Pull Request Test Coverage Report for Build 10801400316

Details

  • 9 of 9 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 5338645060: 0.0%
Covered Lines: 1615
Relevant Lines: 1615

💛 - Coveralls

@barbieri barbieri merged commit c972620 into master Sep 10, 2024
5 checks passed
@barbieri barbieri deleted the deprecate-py-versions branch September 10, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants