Add evalReadOnly & evalShaReadOnly

[BalmungSan]

These were missing and we will need them :)

---

Related: https://redis.io/docs/latest/develop/interact/programmability/#read-only-scripts

[BalmungSan]

Hi @yisraelU I was wondering if the changes look good to be merged or if you would rather have me change something?

We are needing this at work, so I am happy to help in any way to make a new release including these changes, even if as a temporal SNAPSHOT` just to test them and see if we see an improved performance.

[yisraelU]

Hi @yisraelU I was wondering if the changes look good to be merged or if you would rather have me change something?

We are needing this at work, so I am happy to help in any way to make a new release including these changes, even if as a temporal SNAPSHOT` just to test them and see if we see an improved performance.

Hey @BalmungSan , apologies . I wrote a response last week but I see now it says pending and never got published. 🤷
Here is the gist -
Since the Charset is configurable, I think it would be prefered to add a method here to expose the ClientOptions and use the Charset from the options as opposed to fixing it to UTF_8 (even though UTF_8 is the default , it is configurable)
WDYT ?

[BalmungSan]

@yisraelU while I wouldn't mind looking at how to expose that.
You can see that the linked PR in lettuce was merged and will be released as part of 7.0 (although not sure how much time until that).
When that happens, and we upgrade, we can use the overload that accepts a String and that does the encoding using the ChartSet configured by the ClientOps.

IMHO, that is a better solution overall, since we would not duplicate the logic.
Thus, it may be great if we can release a SNAPSHOT from this branch to be usable for us at work, and then when lettuce releases 7.0 we can "fix" this PR and properly merge it.

WDYT?

[yisraelU]

@BalmungSan fair enough . I was originally concerned that 7.0 was a "far off" release, but I can see its the next targeted release.

[yisraelU]

@BalmungSan seems like snapshots are broken , I am looking into it

[BalmungSan]

Thank you very much for the help :)

[yisraelU]

@BalmungSan Snapshots are fixed
Here is the latest version 1.7.0-45-6e6f2c2-SNAPSHOT

[BalmungSan]

@yisraelU amazing, thank you very much!
I will notify the team immediately so they can start using it :D