Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lettuce-core to 6.1.8.RELEASE #675

Merged

Conversation

scala-steward
Copy link
Contributor

Updates io.lettuce:lettuce-core from 6.1.6.RELEASE to 6.1.8.RELEASE.

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Ignore future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "io.lettuce", artifactId = "lettuce-core" } ]

labels: library-update, commit-count:1

Copy link
Member

@gvolpe gvolpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[error] /home/runner/work/redis4cats/redis4cats/modules/core/src/main/scala/dev/profunktor/redis4cats/data.scala:117:39: [deprecation @ dev.profunktor.redis4cats.data.ReadFrom.Nearest | origin=io.lettuce.core.ReadFrom.NEAREST | version=] value NEAREST in class ReadFrom is deprecated
[error]     val Nearest           = JReadFrom.NEAREST
[error]                                       ^
[error] one error found
[error] (redis4cats-core / Compile / compileIncremental) Compilation failed
[error] Total time: 18 s, completed Mar 18, 2022, 1:43:35 PM

@kyri-petrou
Copy link
Collaborator

@gvolpe I pushed a commit to the branch to fix the issue. JReadFrom.NEAREST was deprecated in favour of JReadFrom.LOWEST_LATENCY.

Not sure if I should have used since = "v.1.2.0" or something different in the deprecation message, let me know and I can change it if necessary

@mergify mergify bot merged commit ff2cad7 into profunktor:series/1.x Apr 25, 2022
@kyri-petrou
Copy link
Collaborator

Hmm it seems that Mergify went ahead and merged the PR without respecting the Request Changes status. Do we want that or are we missing a check somewhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants