Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add auth command #427

Merged
merged 2 commits into from
Dec 5, 2020
Merged

Add auth command #427

merged 2 commits into from
Dec 5, 2020

Conversation

mmienko
Copy link
Contributor

@mmienko mmienko commented Dec 5, 2020 •
edited by gvolpe
Loading

Closes #246

gvolpe
gvolpe requested changes Dec 5, 2020
View reviewed changes
Copy link
Member

@gvolpe gvolpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest looks fine.

@mmienko
Copy link
Contributor Author

mmienko commented Dec 5, 2020

The failed build looks to be a flaky test. Double checked that it passes locally.

gvolpe
gvolpe approved these changes Dec 5, 2020
View reviewed changes
Copy link
Member

@gvolpe gvolpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gvolpe gvolpe merged commit de7654e into profunktor:master Dec 5, 2020
@mmienko mmienko deleted the auth-command branch December 5, 2020 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvolpe gvolpe gvolpe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement AUTH command
2 participants
@mmienko @gvolpe