Skip to content
This repository has been archived by the owner on Nov 22, 2022. It is now read-only.

fix(ci status): add check for pending pipelines #869

Merged
merged 1 commit into from
Oct 12, 2021
Merged

fix(ci status): add check for pending pipelines #869

merged 1 commit into from
Oct 12, 2021

Conversation

EduardBaer
Copy link
Contributor

Description

New pipelines might take a while until they have the status "running". During that time they are "pending". I believe glab ci status --live should wait for pipelines that are about to start. Adding this change makes glab wait in those cases instead of showing the "Choose an action" prompt.

How Has This Been Tested?

Manually tested.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation
  • Chore (Related to CI or Packaging to platforms)

@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #869 (509388b) into trunk (f127d7e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            trunk     #869   +/-   ##
=======================================
  Coverage   59.31%   59.31%           
=======================================
  Files          93       93           
  Lines        7384     7384           
=======================================
  Hits         4380     4380           
  Misses       2619     2619           
  Partials      385      385           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f127d7e...509388b. Read the comment docs.

Copy link
Owner

@profclems profclems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @EduardBaer

@profclems profclems merged commit 7ce30c6 into profclems:trunk Oct 12, 2021
@EduardBaer EduardBaer deleted the pipeline-pending branch October 13, 2021 07:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants