-
-
Notifications
You must be signed in to change notification settings - Fork 163
feat: fill MR desc with all commit bodies #819
Conversation
Codecov Report
@@ Coverage Diff @@
## trunk #819 +/- ##
==========================================
- Coverage 59.45% 59.41% -0.05%
==========================================
Files 93 93
Lines 7357 7364 +7
==========================================
+ Hits 4374 4375 +1
- Misses 2601 2607 +6
Partials 382 382
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @guyfedwards. LGTM.
The formatting maybe is not the best, but I can't think of anything better. I am for adding a feature and improving upon it later on
I'm not convinced about this too. Looks really weird. To fix this in markdown, you need two spaces after the first line like so:
This will be rendered as expected:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add usage examples here:
glab/commands/mr/create/mr_create.go
Lines 83 to 88 in 999d1ff
Example: heredoc.Doc(` | |
$ glab mr new | |
$ glab mr create -a username -t "fix annoying bug" | |
$ glab mr create -f --draft --label RFC | |
$ glab mr create --fill --yes --web | |
`), |
8cae6e2
to
8974ac0
Compare
adds --fill-commit-body flag to add all the commit bodies to the MR description when creating an my with --fill closes profclems#795
8974ac0
to
52126c4
Compare
@profclems I have made the requested changes but github seems to be stuck thinking I haven't? |
Description
adds --fill-commit-body flag to add all the commit bodies to the MR description
when creating an my with --fill
closes #795
Related Issue
Resolves #795
How Has This Been Tested?
Wrote tests for this and tested on personal gitlab account
Screenshots (if appropriate):
@profclems @zemzale not sure how I feel about the formatting, ends up looking kinda weird because of the indentation
Types of changes