Skip to content
This repository has been archived by the owner on Nov 22, 2022. It is now read-only.

internal/config: migrate local config to .git/glab-cli #813

Merged
merged 1 commit into from
Aug 11, 2021
Merged

Conversation

profclems
Copy link
Owner

@profclems profclems commented Aug 10, 2021

To set a local config, glab writes to .glab-cli/config/config.yaml and to hide it, writes to .gitignore.

This change migrates the local config to .git/glab-cli to avoid messing with the .gitignore of the current project.

Resolves #791 #384

@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #813 (a9ec9d7) into trunk (b8a02b5) will decrease coverage by 0.15%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk     #813      +/-   ##
==========================================
- Coverage   59.45%   59.29%   -0.16%     
==========================================
  Files          93       93              
  Lines        7357     7353       -4     
==========================================
- Hits         4374     4360      -14     
- Misses       2601     2613      +12     
+ Partials      382      380       -2     
Impacted Files Coverage Δ
internal/config/config_migration.go 0.00% <0.00%> (ø)
internal/config/config_type.go 69.45% <ø> (ø)
internal/config/file.go 100.00% <ø> (+12.90%) ⬆️
internal/config/local_config.go 31.81% <100.00%> (+5.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8a02b5...a9ec9d7. Read the comment docs.

To set a local config, glab writes to .glab-cli/config/config.yaml and
to hide it, writes to .gitignore.
This change migrates the local config to .git/glab-cli to avoid messing with the .gitignore of the current project.
Copy link
Collaborator

@zemzale zemzale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@profclems profclems merged commit 4759d41 into trunk Aug 11, 2021
@profclems profclems deleted the config-fix branch August 11, 2021 08:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core enhancement New feature or request size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration could be in .git/config proposal: save local config to .git/config
2 participants