Skip to content
This repository has been archived by the owner on Nov 22, 2022. It is now read-only.

fix(ci/status): adding list of external jobs #752

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

pvoliveira
Copy link
Contributor

@pvoliveira pvoliveira commented Jun 6, 2021

Description

I use GitLab on my work but the CI is not configured in the GitLab, the status/link is attached to the commit, so when using the command glab ci status I got this error:

Screenshot 2021-06-05 at 22 42 50

This pull request adds one more verification and when no job is found for the pipeline, it tries to list the commit statuses.

Related Issue

Resolves #751

How Has This Been Tested?

The tests were made on a local instance of GitLab.

Screenshots (if appropriate):

Screenshot 2021-06-06 at 01 29 34

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation
  • Chore (Related to CI or Packaging to platforms)

@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

Merging #752 (2f49658) into trunk (178fdb0) will decrease coverage by 0.14%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk     #752      +/-   ##
==========================================
- Coverage   58.61%   58.47%   -0.15%     
==========================================
  Files          93       93              
  Lines        6665     6681      +16     
==========================================
  Hits         3907     3907              
- Misses       2379     2395      +16     
  Partials      379      379              
Impacted Files Coverage Δ
commands/ci/trace/trace.go 58.97% <0.00%> (-15.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 178fdb0...2f49658. Read the comment docs.

Copy link
Owner

@profclems profclems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pvoliveira thanks for working on this... Looks good!

@profclems profclems merged commit 65f9b12 into profclems:trunk Jun 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List "external jobs" associated with the commit.
2 participants