This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It allowes `mr update` to update reviewers with a new flag --reviewers Delivers profclems#562
Codecov Report
@@ Coverage Diff @@
## trunk #694 +/- ##
==========================================
- Coverage 59.95% 59.65% -0.31%
==========================================
Files 90 90
Lines 6450 6496 +46
==========================================
+ Hits 3867 3875 +8
- Misses 2218 2250 +32
- Partials 365 371 +6
Continue to review full report at Codecov.
|
LGTM! |
zemzale
approved these changes
Apr 28, 2021
kousikmitra
commented
Apr 28, 2021
profclems
suggested changes
Apr 29, 2021
profclems
approved these changes
Apr 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @kousikmitra. All looks good now. I added a commit to fix the reviewer action messages
Thanks @profclems :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It allowes
mr update
to update reviewers with a new flag--reviewer
. The behaviour of--reviewer
is same as--assignee
flag but instead it updates reviewers of the merge request.Note: I have made the flag as
--reviewer
instead of--reviewers
to keep consistency with--assignee
Related Issue
Resolves #562
How Has This Been Tested?
Locally tested with
glab mr update --reviewer +name
glab mr update --reviewer -name
glab mr update --reviewer name
glab mr update --reviewer +name --assignee +name
Screenshots (if appropriate):
Types of changes