Skip to content
This repository has been archived by the owner on Nov 22, 2022. It is now read-only.

feat(mr/view): update mr reviewers #694

Merged
merged 2 commits into from
Apr 30, 2021

Conversation

kousikmitra
Copy link
Contributor

Description
It allowes mr update to update reviewers with a new flag --reviewer. The behaviour of --reviewer is same as --assignee flag but instead it updates reviewers of the merge request.

Note: I have made the flag as --reviewer instead of --reviewers to keep consistency with --assignee

Related Issue

Resolves #562

How Has This Been Tested?
Locally tested with
glab mr update --reviewer +name
glab mr update --reviewer -name
glab mr update --reviewer name
glab mr update --reviewer +name --assignee +name

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation
  • Chore (Related to CI or Packaging to platforms)

It allowes `mr update` to update reviewers with a new flag --reviewers
Delivers profclems#562
@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #694 (2e3738f) into trunk (35e792f) will decrease coverage by 0.30%.
The diff coverage is 35.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk     #694      +/-   ##
==========================================
- Coverage   59.95%   59.65%   -0.31%     
==========================================
  Files          90       90              
  Lines        6450     6496      +46     
==========================================
+ Hits         3867     3875       +8     
- Misses       2218     2250      +32     
- Partials      365      371       +6     
Impacted Files Coverage Δ
commands/cmdutils/cmdutils.go 70.88% <35.71%> (-2.80%) ⬇️
commands/mr/mrutils/mrutils.go 65.56% <0.00%> (-14.28%) ⬇️
cmd/glab/main.go 40.22% <0.00%> (-0.95%) ⬇️
pkg/iostreams/iostreams.go 39.36% <0.00%> (ø)
commands/mr/view/mr_view.go 76.82% <0.00%> (+1.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35e792f...2e3738f. Read the comment docs.

@zemzale
Copy link
Collaborator

zemzale commented Apr 28, 2021

LGTM!

@zemzale zemzale requested a review from profclems April 28, 2021 14:45
commands/mr/update/mr_update.go Outdated Show resolved Hide resolved
commands/mr/update/mr_update.go Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/M and removed size/S labels Apr 30, 2021
Copy link
Owner

@profclems profclems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @kousikmitra. All looks good now. I added a commit to fix the reviewer action messages

@kousikmitra
Copy link
Contributor Author

kousikmitra commented Apr 30, 2021

Thanks @profclems :)

@profclems profclems merged commit ecdfc7f into profclems:trunk Apr 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: Update MR reviewer
3 participants