This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
Fix hostnames resolution #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## trunk #667 +/- ##
==========================================
- Coverage 60.00% 59.98% -0.02%
==========================================
Files 90 90
Lines 6458 6460 +2
==========================================
Hits 3875 3875
- Misses 2218 2220 +2
Partials 365 365
Continue to review full report at Codecov.
|
profclems
suggested changes
Mar 25, 2021
|
This PR has been automatically marked as stale because it has not had recent activity. This message is just a reminder for the author, reviewers and assignees. |
When trying to override host with full URLs, config key lookups would fail. This came down to the fact that we use `my.gitlab.com` as config key and when providing override as `https://my.gitlab.com/` it would fail to find this config key. Issue profclems#592
profclems
approved these changes
Apr 30, 2021
profclems
added a commit
that referenced
this pull request
Apr 30, 2021
This allows overriding the default protocol of the hostname if a fully qualified url is provided when using the `GITLAB_HOST` environment variable. For example, if the GITLAB_HOST=http://my.glinstance.org, then the host will be set to my.glinstance.org and the protocol become http, unlike before when the protocol was ignored and only the hostname was considered. This is a follow-up for #678 and #667
profclems
added a commit
to olearycrew/glab
that referenced
this pull request
Jun 12, 2021
This allows overriding the default protocol of the hostname if a fully qualified url is provided when using the `GITLAB_HOST` environment variable. For example, if the GITLAB_HOST=http://my.glinstance.org, then the host will be set to my.glinstance.org and the protocol become http, unlike before when the protocol was ignored and only the hostname was considered. This is a follow-up for profclems#678 and profclems#667
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When overriding host, we now strip protocol from the URL, since we don't need that and it would break config key lookups.
Related Issue
Resolves #592
How Has This Been Tested?
Locally tested with self-hosted GitLab instance
Screenshots (if appropriate):
Types of changes