Skip to content
This repository has been archived by the owner on Nov 22, 2022. It is now read-only.

feat: more interactive options to auth login #641

Merged
merged 1 commit into from
Mar 10, 2021
Merged

Conversation

profclems
Copy link
Owner

@profclems profclems commented Mar 8, 2021

Description

  • This allows interactively setting api_protocol and api_host
  • Adds http to the git_protocol options

Related Issue

Resolves #640 #276

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation
  • Chore (Related to CI or Packaging to platforms)

@profclems profclems added cmd: auth Related to auth command enhancement New feature or request labels Mar 8, 2021
@profclems profclems self-assigned this Mar 8, 2021
@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #641 (b646968) into trunk (b192000) will decrease coverage by 0.32%.
The diff coverage is 3.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk     #641      +/-   ##
==========================================
- Coverage   60.53%   60.20%   -0.33%     
==========================================
  Files          90       90              
  Lines        6362     6393      +31     
==========================================
- Hits         3851     3849       -2     
- Misses       2148     2182      +34     
+ Partials      363      362       -1     
Impacted Files Coverage Δ
commands/auth/login/login.go 42.02% <3.12%> (-7.67%) ⬇️
internal/config/config_file.go 29.06% <0.00%> (-3.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b192000...b646968. Read the comment docs.

- This allows interactively setting api_protocol and api_host
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cmd: auth Related to auth command enhancement New feature or request size/M
Projects
None yet
1 participant