-
-
Notifications
You must be signed in to change notification settings - Fork 163
feat(project.clone): add option to preserve namespaces by subdirectories #627
feat(project.clone): add option to preserve namespaces by subdirectories #627
Conversation
- adds CLI flag to preserve namespaces on git clone - sets the target directory to the Project path with namespace when set - when cloning a group of projects, copy gitArgs to ensure per repo arguments
Codecov Report
@@ Coverage Diff @@
## trunk #627 +/- ##
==========================================
- Coverage 60.51% 60.48% -0.03%
==========================================
Files 90 90
Lines 6357 6365 +8
==========================================
+ Hits 3847 3850 +3
- Misses 2148 2151 +3
- Partials 362 364 +2
Continue to review full report at Codecov.
|
Thanks, for the PR @loupgaroublond If @profclems is up for this I believe this can be merged into trunk |
If you folks can take this as is, that is excellent. Otherwise, happy to open up an issue and go through the change more. There were definitely a few behavioral choices I made unilaterally, that, both, I'd like to change, and I bet others have Strong Opinions on too. If nothing else, we needed this change at work - so here's the change, it'll get active use off my fork, and whenever you're ready, we can merge it back in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@loupgaroublond thanks for working on this! It's a really nice feature.
I'm having a few thoughts on the naming of the --preserve-namespace | p
flag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a better idea for preserve-namespace
, name, but we might go without the p
short flag maybe? I don't think that this flag is such a common thing, and there are already a lot of instances of p
mostly meaning page
for list requests.
I am ok with dropping the short flag. Please stay tuned for a patch to the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On second thought, we can still maintain the -p
shorthand for the --preserve-namespace
flag since this isn't a list
command
Thanks a lot @loupgaroublond for working on this... It will be released as part of v1.16.0
Description
Related Issue
Resolves #[issue_number]
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes