Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make procrastinate.contrib.django.app a proxy #959

Merged
merged 1 commit into from
Mar 2, 2024
Merged

Conversation

ewjoachim
Copy link
Member

@ewjoachim ewjoachim commented Mar 2, 2024

Make procrastinate.contrib.django.app a proxy so that we use the same instance before and after it's ready

Relates to #934.

I don't think we need to talk about it in the doc.
I'm not sure what kind of test would make sense.

Successful PR Checklist:

  • Tests
    • (not applicable?)
  • Documentation
    • (not applicable?)

PR label(s):

so that we use the same instance before and after it's ready
@ewjoachim ewjoachim requested a review from a team as a code owner March 2, 2024 21:16
@github-actions github-actions bot added PR type: feature ⭐️ Contains new features PR type: bugfix 🕵️ Contains bug fix and removed PR type: feature ⭐️ Contains new features labels Mar 2, 2024
@ewjoachim ewjoachim enabled auto-merge March 2, 2024 21:17
@ewjoachim ewjoachim merged commit fa5ee02 into main Mar 2, 2024
13 checks passed
@ewjoachim ewjoachim deleted the django-app-proxy branch March 2, 2024 21:18
Copy link

github-actions bot commented Mar 2, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  procrastinate/contrib/django
  __init__.py
  apps.py
  placeholder.py
Project Total  

This report was generated by python-coverage-comment-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR type: bugfix 🕵️ Contains bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant