Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log exceptions that trigger job retries at INFO #845

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Log exceptions that trigger job retries at INFO #845

merged 2 commits into from
Oct 5, 2023

Conversation

ashleyheath
Copy link
Contributor

Closes #708

Successful PR Checklist:

  • Tests
    • (not applicable?)
  • Documentation
    • (not applicable?)

@ashleyheath ashleyheath requested a review from a team as a code owner October 5, 2023 09:28
@ashleyheath ashleyheath mentioned this pull request Oct 5, 2023
Closed
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Coverage report

The coverage rate went from 99.33% to 99.33% ⬆️
The branch rate is 98%.

100% of new lines are covered.

Diff Coverage details (click to unfold)

procrastinate/worker.py

100% of new lines are covered (100% of the complete file).

ewjoachim
ewjoachim approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@ewjoachim ewjoachim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems great !

@ewjoachim ewjoachim merged commit c126d8f into procrastinate-org:main Oct 5, 2023
6 checks passed
@ewjoachim
Copy link
Member

https://github.com/procrastinate-org/procrastinate/releases/tag/0.29.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewjoachim ewjoachim ewjoachim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Log expected exceptions triggering retries at non-error level
2 participants
@ashleyheath @ewjoachim