Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add state graph (using mermaid) to the discussion page #1208

Merged
merged 5 commits into from
Oct 1, 2024
Merged

Add state graph (using mermaid) to the discussion page #1208

merged 5 commits into from
Oct 1, 2024

Conversation

medihack
Copy link
Member

Closes #1137

Successful PR Checklist:

  • Tests
    • (not applicable?)
  • Documentation
    • (not applicable?)

PR label(s):

@medihack medihack requested a review from a team as a code owner September 30, 2024 22:24
@github-actions github-actions bot added the PR type: documentation 📚 Contains documentation updates label Sep 30, 2024
@github-actions GitHub Actions
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

ewjoachim
ewjoachim approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@ewjoachim ewjoachim left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome !

Screenshot 2024-10-01 at 23 11 48 Screenshot 2024-10-01 at 23 11 34

https://procrastinate--1208.org.readthedocs.build/en/1208/discussions.html#what-are-the-different-states-of-a-job-and-how-do-they-go-from-one-to-another

It looks great on light mode and readable on dark mode.
Just a few wording suggestions to make it easier to parse.

docs/discussions.md Outdated Show resolved Hide resolved
docs/discussions.md Outdated Show resolved Hide resolved
docs/discussions.md Outdated Show resolved Hide resolved
medihack and others added 3 commits October 1, 2024 23:37
@medihack @ewjoachim
Update docs/discussions.md
c51f70d 
Co-authored-by: Joachim Jablon <[email protected]>
@medihack @ewjoachim
Update docs/discussions.md
c7d20f9 
Co-authored-by: Joachim Jablon <[email protected]>
@medihack @ewjoachim
Update docs/discussions.md
94b74fd 
Co-authored-by: Joachim Jablon <[email protected]>
@medihack medihack merged commit 183d133 into procrastinate-org:v3 Oct 1, 2024
11 checks passed
@medihack medihack mentioned this pull request Oct 1, 2024
Closed
@ewjoachim ewjoachim mentioned this pull request Dec 1, 2024
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewjoachim ewjoachim ewjoachim approved these changes

Assignees
No one assigned
Labels
PR type: documentation 📚 Contains documentation updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@medihack @ewjoachim