Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abort job polling interval #1192

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

onlyann
Copy link
Contributor

@onlyann onlyann commented Sep 13, 2024

Closes #1184

Successful PR Checklist:

  • Tests
    • (not applicable?)
  • Documentation
    • (not applicable?)

PR label(s):

Changes

This adds abort_job_polling_interval to be able to specify a different interval for polling abort requests.
It also renames polling_interval to fetch_job_polling_interval.

@onlyann onlyann requested a review from a team as a code owner September 13, 2024 23:01
@github-actions github-actions bot added PR type: feature ⭐️ Contains new features PR type: documentation 📚 Contains documentation updates labels Sep 13, 2024
Copy link

github-actions bot commented Sep 13, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  procrastinate
  app.py
  cli.py
  worker.py
Project Total  

This report was generated by python-coverage-comment-action

@onlyann
Copy link
Contributor Author

onlyann commented Sep 13, 2024

Two things I was wondering:

  • Should the existing polling option continue to be polling_interval or should it be renamed to something like fetch_polling_interval?

  • What should be the default for abort_polling_interval ?
    I kept it to the same default of 5 seconds.

@medihack
Copy link
Member

Two things I was wondering:

  • Should the existing polling option continue to be polling_interval or should it be renamed to something like fetch_polling_interval?
  • What should be the default for abort_polling_interval ?
    I kept it to the same default of 5 seconds.

Yes, in my opinion it would make sense to rename the polling_interval to make things more clear (even to fetch_job_polling_interval).

@onlyann onlyann force-pushed the abort-polling-interval branch from 9fb112c to 5039b9b Compare September 16, 2024 03:31
@onlyann onlyann changed the title Abort polling interval Abort job polling interval Sep 16, 2024
Copy link
Member

@ewjoachim ewjoachim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect.

🎉

@ewjoachim ewjoachim merged commit 8a1c039 into procrastinate-org:v3 Sep 19, 2024
13 checks passed
@ewjoachim ewjoachim added this to the Version 3.0 milestone Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR type: documentation 📚 Contains documentation updates PR type: feature ⭐️ Contains new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants