Merge pull request #1013 from procrastinate-org/warnings

procrastinate/metadata.py

@@ -8,9 +8,9 @@ def extract_metadata() -> Mapping[str, str]:
     metadata = importlib_metadata.metadata("procrastinate")
 
     return {
-        "author": metadata["Author"],
-        "email": metadata["Author-email"],
-        "license": metadata["License"],
-        "url": metadata["Home-page"],
-        "version": metadata["Version"],
+        "author": metadata.get("Author", ""),
+        "email": metadata.get("Author-email", ""),
+        "license": metadata.get("License", ""),
+        "url": metadata.get("Home-page", ""),
+        "version": metadata.get("Version", ""),
     }

pyproject.toml

@@ -71,6 +71,9 @@ pytest-cov = "*"
 pytest-django = "*"
 pytest-mock = "*"
 migra = "*"
+# migra depends on schemainspect, which has an implicit dependency on setuptools
+# (pkg_resources).
+setuptools = { version = "*", python = ">=3.12" }
 
 [tool.poetry.group.docs.dependencies]
 django = ">=2.2"
@@ -103,7 +106,10 @@ testpaths = [
     "tests/acceptance",
     "tests/migration",
 ]
-filterwarnings = ""
+filterwarnings = """
+    error
+    ignore:unclosed.+:ResourceWarning
+"""
 asyncio_mode = "auto"
 DJANGO_SETTINGS_MODULE = "tests.acceptance.django_settings"
 

tests/integration/test_manager.py

@@ -284,7 +284,9 @@ async def test_finish_job_wrong_end_status(
 async def test_retry_job(pg_job_manager, fetched_job_factory):
     job1 = await fetched_job_factory(queue="queue_a")
 
-    await pg_job_manager.retry_job(job=job1, retry_at=datetime.datetime.utcnow())
+    await pg_job_manager.retry_job(
+        job=job1, retry_at=datetime.datetime.now(datetime.timezone.utc)
+    )
 
     job2 = await pg_job_manager.fetch_job(queues=None)
 
@@ -480,23 +482,12 @@ async def test_list_tasks_dict(fixture_jobs, pg_job_manager):
     }
 
 
-async def test_list_locks_dict(fixture_jobs, job_factory, pg_job_manager):
-    pg_job_manager.defer_job_async(
-        job=job_factory(
-            queue="q3",
-            lock=None,
-            queueing_lock="queueing_lock3",
-            task_name="task_foo",
-            task_kwargs={"key": "a"},
-        )
-    )
-    assert (await pg_job_manager.list_locks_async())[0] == {
-        "name": "lock1",
-        "jobs_count": 1,
-        "todo": 1,
-        "doing": 0,
-        "succeeded": 0,
-        "failed": 0,
+async def test_list_locks_dict(fixture_jobs, pg_job_manager):
+    assert {e["name"] for e in await pg_job_manager.list_locks_async()} == {
+        "lock1",
+        "lock2",
+        "lock3",
+        "lock4",
     }
 
 

tests/migration/test_migration.py

@@ -2,16 +2,26 @@
 
 import contextlib
 import pathlib
+import warnings
 
 import pytest
 from django.core import management
 from django.db import connection
-from migra import Migration
 from sqlalchemy.pool import NullPool
 from sqlbag import S
 
 from procrastinate import psycopg_connector, schema
 
+with warnings.catch_warnings(record=True):
+    # migra uses schemainspect which uses pkg_resources which is deprecated
+    warnings.filterwarnings(
+        action="ignore", category=DeprecationWarning, module="pkg_resources"
+    )
+    warnings.filterwarnings(
+        action="ignore", category=DeprecationWarning, module="schemainspect"
+    )
+    from migra import Migration
+
 
 @pytest.fixture
 def run_migrations(db_execute):