Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

required_lookup_attributes_for could be nil #59

Closed
wants to merge 1 commit into from
Closed

required_lookup_attributes_for could be nil #59

wants to merge 1 commit into from

Conversation

philipqnguyen
Copy link
Contributor

So we need to remove the nil cases.

@philipqnguyen
required_lookup_attributes_for could be nil
a6451b7 
So we need to remove the nil cases.
@philipqnguyen philipqnguyen self-assigned this Jan 18, 2018
@philipqnguyen
Copy link
Contributor Author

philipqnguyen commented Jan 19, 2018 •
edited
Loading

maybe wont need this PR, depending on how we go with #60

@philipqnguyen
Copy link
Contributor Author

closing this because #61 was merged, nullifying this PR

@philipqnguyen philipqnguyen deleted the nil-lookup-attrs branch January 25, 2018 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcclayton mcclayton mcclayton approved these changes

@dlcarter dlcarter Awaiting requested review from dlcarter

@AllPurposeName AllPurposeName Awaiting requested review from AllPurposeName

Assignees

@philipqnguyen philipqnguyen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philipqnguyen @mcclayton