Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow transformers to be included across views #372

Merged
merged 14 commits into from
Jan 12, 2024
Merged

Allow transformers to be included across views #372

merged 14 commits into from
Jan 12, 2024

Commits on Nov 23, 2023

  1. Allowing to use included views transformer from the current view 

    Signed-off-by: bhooshiek <[email protected]>
    @bhooshiek-narendiran
    bhooshiek-narendiran committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    2d3c9c7 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2023

  1. Merge branch 'main' into nested_transformers

    @bhooshiek-narendiran
    bhooshiek-narendiran committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    e3c8ecc View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2023

  1. Improve logic for gathering transformers from included views. 

    Signed-off-by: Nate Baer <[email protected]>
    @njbbaer
    njbbaer committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    8815272 View commit details
    Browse the repository at this point in the history

  2. Add view collection spec 

    Signed-off-by: Nate Baer <[email protected]>
    @njbbaer
    njbbaer committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    dec674f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into nb/nested_transformers

    @njbbaer
    njbbaer authored Dec 26, 2023
    Configuration menu
    Copy the full SHA
    1bcae06 View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2023

  1. - View transformers should combine with default transformers instead … 

    …of replace them.

- Enhance view collection test suite and address comments.

Signed-off-by: Nate Baer <[email protected]>
    @njbbaer
    njbbaer committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    8e20388 View commit details
    Browse the repository at this point in the history

  2. Fix handling of configured default_transformers, which is only used i… 

    …f there are no view transformers.

Signed-off-by: Nate Baer <[email protected]>
    @njbbaer
    njbbaer committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    0acf5d1 View commit details
    Browse the repository at this point in the history

  3. Remove failing test for logic that was moved. 

    Signed-off-by: Nate Baer <[email protected]>
    @njbbaer
    njbbaer committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    1ca67b2 View commit details
    Browse the repository at this point in the history

  4. - Add documentation for including transformers across views. 

    - Minor textual changes to view collection spec.

Signed-off-by: Nate Baer <[email protected]>
    @njbbaer
    njbbaer committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    c723f9e View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. Use subject instead of let in view collection spec. 

    Signed-off-by: Nate Baer <[email protected]>
    @njbbaer
    njbbaer committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    04564e6 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. Execute transformers in a top-down order. 

    Signed-off-by: Nate Baer <[email protected]>
    @njbbaer
    njbbaer committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    fe71331 View commit details
    Browse the repository at this point in the history

  2. Remove pry import from spec helper. 

    Signed-off-by: Nate Baer <[email protected]>
    @njbbaer
    njbbaer committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    23b167e View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2024

  1. Merge branch 'main' into nb/nested_transformers

    @njbbaer
    njbbaer authored Jan 10, 2024
    Configuration menu
    Copy the full SHA
    6d39a88 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2024

  1. Merge branch 'main' into nb/nested_transformers

    @njbbaer
    njbbaer authored Jan 11, 2024
    Configuration menu
    Copy the full SHA
    012a8dc View commit details
    Browse the repository at this point in the history