Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: setup github stuff #307

Merged
merged 14 commits into from
Jul 28, 2023
Merged

chore: setup github stuff #307

merged 14 commits into from
Jul 28, 2023

Conversation

jmeridth
Copy link
Contributor

@jmeridth jmeridth commented Jun 21, 2023

  • switch to 2.7+ ruby versions in tests
  • github actions for tests and release instead of circleci
  • dependabot
  • stale github action postponing until we've reviewed all existing issues and PRs
  • auto assign author github action
  • update README tests badge
  • add CONTRIBUTING.md, CODE_OF_CONDUCT.md, and .github/PULL_REQUEST_TEMPLATE.md
  • put secrets into github

@jmeridth
Copy link
Contributor Author

Note: All versions of Ruby are EOL, we should look at changing CI to accept 2.7+ only.

@jmeridth jmeridth self-assigned this Jun 21, 2023
@jmeridth jmeridth force-pushed the jm/github-ations-etc branch 2 times, most recently from c23a799 to f7fa712 Compare July 14, 2023 15:57
@jmeridth
Copy link
Contributor Author

Looks like the current github action failures (ruby 2.2) are related to this. No fix available. Going to go back to newer versions of ruby.

@jmeridth jmeridth force-pushed the jm/github-ations-etc branch 5 times, most recently from 4c8a140 to 698fc52 Compare July 21, 2023 15:02
@jmeridth jmeridth mentioned this pull request Jul 21, 2023
@jmeridth
Copy link
Contributor Author

This is working with 2.7 but fails with ruby 3.0+. Will fix for 3.0+ and handle 2.7 retroactively due to known legacy apps that are using blueprinter.

- [x] github actions for tests and release instead of circleci
  - [ ] add secrets to repository
- [x] dependabot
- [x] stale github action
- [x] auto assign author github action
- [x] update README tests badge
- [x] add CONTRIBUTING.md, CODE_OF_CONDUCT.md, and .github/PULL_REQUEST_TEMPLATE.md

Signed-off-by: jmeridth <[email protected]>
@jmeridth jmeridth marked this pull request as ready for review July 26, 2023 14:43
@jmeridth jmeridth marked this pull request as draft July 26, 2023 14:45
@jmeridth
Copy link
Contributor Author

jmeridth commented Jul 26, 2023

@lessthanjacob fixing the build failures. Awesome. Thank you.

Now getting the secrets in place so once this merges to master it publishes to rubygems. done

just need to figure out what the bot email and name are and if they are still needed. This

Signed-off-by: jmeridth <[email protected]>
- [x] add specific filenames to pull request template
- [x] add blurb about this PR to changelog (will need to modify date once ready)

Signed-off-by: jmeridth <[email protected]>
lessthanjacob and others added 3 commits July 26, 2023 13:19
- [x] only release if a change occurred to the lib/blueprinter/version.rb file
- [x] change test job from test-ruby2 to just test

Signed-off-by: jmeridth <[email protected]>
this allows dependabot to automate updates when new releases occur

Signed-off-by: jmeridth <[email protected]>
can decide if we want a new gem later after other PRs merge

Signed-off-by: jmeridth <[email protected]>
@jmeridth jmeridth marked this pull request as ready for review July 28, 2023 01:48
@jmeridth
Copy link
Contributor Author

@lessthanjacob @jamesmcguirepro I simplified the release github action. One more review and this is ready to merge IMO.

@jmeridth jmeridth merged commit 24200af into master Jul 28, 2023
4 checks passed
@jmeridth jmeridth deleted the jm/github-ations-etc branch July 28, 2023 20:18
philipqnguyen added a commit to philipqnguyen/blueprinter that referenced this pull request Aug 17, 2023
This releases the gem to 0.27.0. It drops support for any ruby version
less than 2.7. See procore-oss#307

Signed-off-by: philipqnguyen <[email protected]>
philipqnguyen added a commit to philipqnguyen/blueprinter that referenced this pull request Aug 17, 2023
This releases the gem to 0.26.0. It drops support for any ruby version
less than 2.7. See procore-oss#307

Signed-off-by: philipqnguyen <[email protected]>
philipqnguyen added a commit to philipqnguyen/blueprinter that referenced this pull request Aug 17, 2023
This releases the gem to 0.26.0. It drops support for any ruby version
less than 2.7. See procore-oss#307

Signed-off-by: Philip Nguyen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants