Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting view causes state change on default view #204

Merged
merged 1 commit into from
Mar 16, 2020
Merged

Setting view causes state change on default view #204

merged 1 commit into from
Mar 16, 2020

Conversation

trevorrjohn
Copy link
Contributor

This PR fails at this moment I was hoping someone could help me debug why it fails.

@trevorrjohn trevorrjohn changed the title [WIP] Setting view causes state change on default view Setting view causes state change on default view Mar 16, 2020
@trevorrjohn
Copy link
Contributor Author

So I found the issue, #merge_fields was using #merge! which is modifies the object.

@nolanprocore
Copy link

Hi Trevor. Thanks so much for contributing. We'll take a look soon.

@philipqnguyen
Copy link
Contributor

lgtm

@philipqnguyen
Copy link
Contributor

whoops didnt mean to accidentally close this

@trevorrjohn
Copy link
Contributor Author

No rush, but as this is a bug fix I would love to get this merged and released so that I don't have to maintain a fork.

@mcclayton mcclayton merged commit bb07d6f into procore-oss:master Mar 16, 2020
@trevorrjohn trevorrjohn deleted the view-state branch March 16, 2020 20:41
@mcclayton mcclayton mentioned this pull request Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants