Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude multiple fields inline #141

Merged
merged 3 commits into from
Apr 4, 2019

Conversation

pabhinaya
Copy link
Contributor

@pabhinaya pabhinaya commented Mar 21, 2019

@mcclayton , For derived views with multiple included views, ability to exclude multiple fields inline.

Copy link
Contributor

@philipqnguyen philipqnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pabhinaya this is a great addition! Would you add a test for exclude_fields?

@mcclayton
Copy link
Contributor

mcclayton commented Mar 25, 2019

Yes thank you so much for your contribution. As Philip pointed out, it'd be great if you wouldn't mind adding a test to view_spec.rb similar to: https://github.com/procore/blueprinter/blob/master/spec/units/view_spec.rb#L15-L23
and then I can handle drafting up the release/version bump/CHANGELOG entry.

@pabhinaya
Copy link
Contributor Author

@philipqnguyen, @mcclayton I have added the specs for exclude_fields. Please proceed.

@ritikesh
Copy link
Collaborator

ritikesh commented Apr 1, 2019

I believe exclude should be able to take 1 or more arguments. Both the below examples should be valid usages of exclude:

exclude :field1
exclude :field1, :field2

This should be possible with Ruby's splat operator.

@philipqnguyen
Copy link
Contributor

@ritikesh normally I would agree with your suggestion too, but I think having plural excludes would fit with current patterns: ie.,field for single and fields for multiple fields.

Copy link
Contributor

@mcclayton mcclayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll draft a release for this after this is merged if this looks good to @philipqnguyen

@mcclayton mcclayton merged commit a05ad6a into procore-oss:master Apr 4, 2019
@mcclayton mcclayton mentioned this pull request Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants