-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exclude multiple fields inline #141
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pabhinaya this is a great addition! Would you add a test for exclude_fields
?
Yes thank you so much for your contribution. As Philip pointed out, it'd be great if you wouldn't mind adding a test to |
@philipqnguyen, @mcclayton I have added the specs for exclude_fields. Please proceed. |
I believe exclude should be able to take 1 or more arguments. Both the below examples should be valid usages of exclude: exclude :field1 exclude :field1, :field2 This should be possible with Ruby's splat operator. |
@ritikesh normally I would agree with your suggestion too, but I think having plural |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll draft a release for this after this is merged if this looks good to @philipqnguyen
@mcclayton , For derived views with multiple included views, ability to exclude multiple fields inline.