-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implemented border when hover #566
Conversation
✅ Deploy Preview for java-processing-faf822 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @SableRaf , I wanted to let you know that I’ve closed the earlier PR due to some issues and have submitted a new one. The updates have been made, and I’ve addressed everything as per our discussion. Please review the new PR and let me know if there are any changes or issues you’d like me to handle. Looking forward to your feedback! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Rishabdev,
Thank you for your work! Looking good, just checked it and on Safari the text-wrap pretty doesn't work, this doesn't have to hold up this PR in my opinion but if you have a second to fix that would be greatly appreciated!
I noticed the text-wrap issue on Safari as well. I’ll take a quick look at it and see if I can push a fix soon. |
Hi @SableRaf , I’ve made a small change to address the issue, replacing text-wrap: pretty with overflow-wrap: break-word for better compatibility across browsers. Let me know if anything else comes up! |
Hi @SableRaf , I also noticed some extra padding on the left, so I removed the padding-left from .toItem to improve the alignment. Should be all set now! |
Thanks for the great work @rishabdev2997! I've merged the PR. Looking forward to your future contributions! |
feat: Highlight or add left border to active navbar subitem
#487 - added the feature.
In the issue the problem was not mentioned properly(the download nav item gets a left border for distinction. The same can apply to nav sub-items.) but it seems it indicates navs under the "Table of Contents" section must display the same left border upon selection.
How to see the changes
Go to documentation.
Go the environment.
Now move your mouse over the contents of the table.
Here is the Screenshot
20240826180247.mp4