-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes issue #5603 #5604
Fixes issue #5603 #5604
Conversation
This reverts commit b8c5da3. reverts commit from another pull request
It turns out that browser actually track the checked state for radio button inputs using a JavaScript property separately/in addition to the
|
Oh ok...So, as I understand it, we will have to update the JavaScript using Ok, making the changes as you mentioned pronto. Thanks for the update! |
From what I can see the issue seems to be fixed now with this PR. @sflanker Would you like to double check this before I merge? |
The change looks good to me. |
Looks good. Thanks! |
Resolves #5603
####Screenshots of the change:
The issue, as illustrated below, is whenever we cycled through the radio button selections in the code, the
checked=true
option is not removed after each subsequent change. Therefore, after one cycle, all options havechecked=true
and the program malfunctions.The expected behavior:
PR Checklist
npm run lint
passesAcknowledgement: Credit goes to @sflanker for solving the problem in the issue itself, I simply implemented it selectively in the source code.