Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add internal functions for changing translation language in i18next #5443

Merged
merged 1 commit into from
Oct 12, 2021

Conversation

outofambit
Copy link
Contributor

This is some foundational work for allowing the web editor to change the translation language used for FES messages in a running p5.js sketch. These changes don't expose any functionality externally, I've just written wrappers around the underlying i18next functions that make these changes so its easier for others to work with within p5.js.

cc @almchung

PR Checklist

  • npm run lint passes
  • [Inline documentation] is included / updated

@outofambit outofambit added Friendly Errors Internationalization Relates to 'src/core/internationalization.js' labels Oct 8, 2021
@almchung
Copy link
Contributor

This is great! I'll wait for the merge and then add the web editor - FES i18n integration features to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Friendly Errors Internationalization Relates to 'src/core/internationalization.js'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants