Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test fix to resolve #5367 #5412

Merged
merged 6 commits into from
Sep 15, 2021
Merged

Conversation

almchung
Copy link
Contributor

@almchung almchung commented Sep 14, 2021

Addresses #5367

Changes:

  • Updated strings in core/friendly_errors/browser_errors.js to match Chrome browser's error messages.
  • Minor change in millis() unit test from utilities/time_data to include an edge case.

It seems to pass all lint + unit tests, but I'm not confident about my millis() unit test fix. Feedback from anyone would be appreciated!

PR Checklist

@limzykenneth
Copy link
Member

This solves the problem of updating puppeteer to 10.2.0 and npm install now works on ARM with 10.2.0 (tested on Raspberry Pi 4, haven't tested it on M1 Macs yet), however it does not solve the problem with node 16 as presented in #5367. I'll merge this first and figure out what to do about node 16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants