Improve documentation clarity of shader methods #5307
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor changes to the wording used in the following shader methods, with the goal of improving clarity.
loadShader()
1) Reword
Current:
Change:
2) Omit this statement
Current:
3) Be consistent
Current:
Change:
4) Add disclaimer
createShader()
1) Reword
Change:
2) Add disclaimer
shader()
0) Just a thought
I think in hindsight,
setShader()
would have been a better name for this function. Because the shader program created bycreateShader()
orloadShader()
is what people think of as the shader.1) Reword
Current:
Change:
2) Parameter is not optional
Current:
Change:
3) Add disclaimer
resetShader()
1) Reword
Current:
Change:
setUniform()
1) Replace with user-friendly description
Current:
Change:
2) Improve description
Current:
Change:
3)
Object
not a valid data typeCurrent:
Change:
4) Replace with user-friendly description
Current:
Change:
Screenshots of the change
loadShader
createShader
shader
resetShader
setUniform