Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect parameter description for p5.Geometry #5574

Closed
1 of 17 tasks
reejuBhattacharya opened this issue Jan 21, 2022 · 2 comments · Fixed by #5575
Closed
1 of 17 tasks

Incorrect parameter description for p5.Geometry #5574

reejuBhattacharya opened this issue Jan 21, 2022 · 2 comments · Fixed by #5575
Labels

Comments

@reejuBhattacharya
Copy link
Contributor

Most appropriate sub-area of p5.js?

  • Accessibility (Web Accessibility)
  • Build tools and processes
  • Color
  • Core/Environment/Rendering
  • Data
  • DOM
  • Events
  • Friendly error system
  • Image
  • IO (Input/Output)
  • Localization
  • Math
  • Unit Testing
  • Typography
  • Utilities
  • WebGL
  • Other (specify if possible)

p5.js version

No response

Web browser and version

No response

Operating System

No response

Steps to reproduce this

image

detailX and detailY have the same description.

Wouldn't the highlighted word be "vertical"?

@aferriss
Copy link
Contributor

Yep, good catch! Should probably be vertical. I would also say that I think this is kind of a confusing description. Maybe something better might be:

detailX — Integer: Number of vertices along the x axis
detailY — Integer: Number of vertices along the y axis

@reejuBhattacharya
Copy link
Contributor Author

Thanks, I'll send a pull request fixing this asap!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants