Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing Pagination while rendering examples. #2958

Closed
wants to merge 3 commits into from
Closed

Implementing Pagination while rendering examples. #2958

wants to merge 3 commits into from

Conversation

DrizzyOVO
Copy link

@DrizzyOVO DrizzyOVO commented Jan 26, 2024

Fixes #2952

Changes: I added pagination to the sketches section.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123
p5.js.Web.Editor._.Pagination.mp4

Copy link

release-com bot commented Jan 26, 2024

Release Environments

This Environment is provided by Release, learn more!
To see the status of the Environment click on Environment Status below.

🔧Environment Status : https://app.release.com/public/Processing%20Foundation/env-ad16a6a8f5

@DrizzyOVO
Copy link
Author

@lindapaiste what more design is expected? can you explain it please?

@lindapaiste
Copy link
Collaborator

@lindapaiste what more design is expected? can you explain it please?

The pagination buttons are a totally new design element so we need to put some thought into what we want them to look like. In my opinion the hot pink is too over-emphasized but I'm not a designer.

@DrizzyOVO
Copy link
Author

@lindapaiste I've made a few changes. This ui makes it litter easier for users to navigate.

p5.js.Web.Editor._.Pagination_pc.mp4
p5.js.Web.Editor._.Pagination_mobile.mp4

@DrizzyOVO DrizzyOVO closed this by deleting the head repository Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementing Pagination while rendering examples
2 participants