Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add negative number validation to getEnergy() #730

Merged
merged 1 commit into from
Jan 22, 2023
Merged

add negative number validation to getEnergy() #730

merged 1 commit into from
Jan 22, 2023

Conversation

KevinGrajeda
Copy link
Contributor

Closes #665

  • Added validation for negative frequency values
  • added 'frequency must be >= 0' to getEnergy() docs
  • removed duplicate 'Energy' in docs

Abhijay007
Abhijay007 approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@Abhijay007 Abhijay007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

davepagurek
davepagurek approved these changes Jan 22, 2023
View reviewed changes
Copy link
Contributor

@davepagurek davepagurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@davepagurek davepagurek merged commit 76bac0a into processing:main Jan 22, 2023
@KevinGrajeda KevinGrajeda deleted the error-fft-getenergy branch January 22, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abhijay007 Abhijay007 Abhijay007 approved these changes

@davepagurek davepagurek davepagurek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getEnergy() throws error with zero as first argument, but not for second, and not for negative numbers
3 participants
@KevinGrajeda @davepagurek @Abhijay007