Test added to p5.fft #611
Test added to p5.fft #611
Conversation
|
@therewasaguy please have a look |
| try { | ||
| fft.setInput(soundFile); | ||
| } catch (err) { | ||
| return done(err); |
There was a problem hiding this comment.
it catches an error , right now i am unsure of why we cant set sounfile as input , any suggestions @therewasaguy
There was a problem hiding this comment.
@davepagurek any thoughts on this?
There was a problem hiding this comment.
Interesting, I can't actually reproduce this error, it seems to just work. Maybe it was a browser bug that has since been fixed?
There was a problem hiding this comment.
I will try to reproduce this error, if it works we can merge this one.
There was a problem hiding this comment.
@davepagurek it was dropping these errors for me :
but when I added: let fft = new p5.FFT(); it got resolved, anything else seems fine to me.
There was a problem hiding this comment.
Oh does this happen when running tests headless from the other open PR? I'm running npm run test and going to http://localhost:8000/test/?grep=FFT, which is what shows no errors.
Where are you adding the new p5.FFT() line? It also has that in a beforeEach, but maybe something is up with the asynchronous tests 🤔
There was a problem hiding this comment.
Ya I am getting that while running the test headless, I added the new line within the function, at the very beginning just like we did for oscillator = new p5.Oscillator();
added tests for
setInputmethod of p5.fftadded some lint fix to src/looper.js