feat: add a method to only get BPMN semantic of elements by kind #2841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Complement the existing method that also retrieves DOM information. This simplifies the API usage and reduce the amount of retrieved data when the caller only needs to get the information from the model. In addition: - Simplify the existing `getElementsByKinds` implementation: use a flat array instead of an array of array. This is then also consistent with the implementation of the new method. - Use the new API in demo to simplify the code. - Rework the existing JSDoc for consistency
tbouffard
added
enhancement
|
♻️ PR Preview bcd6c37 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
|
♻️ PR Preview bcd6c37 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
tbouffard
changed the title
|
Kudos, SonarCloud Quality Gate passed! |
csouchet
approved these changes
Aug 31, 2023
tbouffard
deleted the
feat/elements_registry_add_getModelElementsByKinds
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complement the existing method that also retrieves DOM information. This simplifies the API usage and reduce the amount of retrieved data when the caller only needs to get the information from the model.
In addition:
getElementsByKindsimplementation: use a flat array instead of an array of array. This is then also consistent with the implementation of the new method.closes #2813