Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[POC] Use overlays with popperjs #1098

Closed
wants to merge 10 commits into from
Closed

[POC] Use overlays with popperjs #1098

wants to merge 10 commits into from

Conversation

csouchet
Copy link
Member

No description provided.

@csouchet csouchet added WIP 🚧 Pull request in progress and/or not ready for review. Used in addition to marking it as draft poc 💫 Experimentation to discuss about future implementation. Not intended to be merged BPMN diagram usability Something about the way we can interact with BPMN diagrams labels Feb 10, 2021
@csouchet csouchet force-pushed the poc/overlays_with_popperjs branch 3 times, most recently from d58f013 to 2eb949b Compare February 16, 2021 17:42
@sonarcloud
Copy link

sonarcloud bot commented Feb 16, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

6.7% 6.7% Coverage
0.0% 0.0% Duplication

@csouchet
Copy link
Member Author

csouchet commented Feb 17, 2021 •
edited
Loading

  • strategy: 'fixed' => The overlay never moves, when we fit/zoom/pan.
  • strategy: 'absoluted' => The overlay moves,but not at the same place on the diagram, when we fit/zoom/pan.

@csouchet csouchet force-pushed the poc/overlays_with_popperjs branch 2 times, most recently from c567dd6 to 0d2da69 Compare February 18, 2021 10:24
@tbouffard
Copy link
Member

tbouffard commented Feb 19, 2021 •
edited
Loading

@csouchet new poperjs releases

@csouchet csouchet force-pushed the poc/overlays_with_popperjs branch 2 times, most recently from 6c3ffe6 to f4cd608 Compare February 22, 2021 09:52
@github-actions
Copy link

github-actions bot commented Feb 22, 2021 •
edited
Loading

🎊 PR Preview 9c70dcd has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-demo_preview-pr-1098.surge.sh

🕐 Build time: 78.175s

🤖 By surge-preview

@csouchet csouchet force-pushed the poc/overlays_with_popperjs branch 3 times, most recently from 86d60cd to 9ee9115 Compare February 22, 2021 14:47
@csouchet csouchet force-pushed the poc/overlays_with_popperjs branch 2 times, most recently from abcd46e to 2e95de3 Compare March 2, 2021 17:35
@tbouffard
Copy link
Member

As per Team decision (#955 (comment)), we are not going to use popperjs.
So closing this POC.

@tbouffard tbouffard closed this Mar 15, 2021
@tbouffard tbouffard deleted the poc/overlays_with_popperjs branch March 15, 2021 15:56
@tbouffard tbouffard mentioned this pull request Mar 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
BPMN diagram usability Something about the way we can interact with BPMN diagrams poc 💫 Experimentation to discuss about future implementation. Not intended to be merged WIP 🚧 Pull request in progress and/or not ready for review. Used in addition to marking it as draft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csouchet @tbouffard