generated from process-analytics/bpmn-visualization-demo-template
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add resource allocation interaction (1st step) #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
♻️ PR Preview c20f3ca has been successfully destroyed since this PR has been closed. 🤖 By surge-preview |
…d better variable names
…ke it work on 'res allocation'
tbouffard
changed the title
feat: add resource allocation interaction
feat: add resource allocation interaction (1st step)
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When clicking on the "Allocate more resource" button, the sub-process diagram is displayed.
When clicking on the "Contact-Client" button, a window alert is displayed. In the future, it will display the 2nd process of the diagram and it will let interact with it.
Implementation notes
This PR introduces refactoring to better encapsulate the logic.
In particular, it provides classes that may be reused outside this demo and served as starting point for experimental features
BpmnElementsSearcher
[FEAT] Add a new experimental API to get a edge/node by name bpmn-visualization-js#2453PathResolver
[FEAT] Provide a way to style BPMN traces/paths bpmn-visualization-js#930 [FEAT] Improvements required to support "style the BPMN traces/paths" bpmn-visualization-js#2402BpmnElementsIdentifier
: simplify the detection/identification of a BPMN Element (is activity, gateway, event) by only providing its idThe case monitoring data are fully managed by dedicated classes both for the main process and the sub-process.
Other parts of the code are still leaking the use cases at several places. This will be refactored later to limit the size of this PR.
Screenshots
Note: we see that several event listeners are registered on the button (as the window alert opens several times)
bonita-day-demo-2023_PR-10.mp4