Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update beta_binom_post_plot.py #690

Merged
merged 1 commit into from
Mar 13, 2022
Merged

Update beta_binom_post_plot.py #690

merged 1 commit into from
Mar 13, 2022

Conversation

patel-zeel
Copy link
Collaborator

Description

Updated the code that generates figure 4.10 to avoid the confusion between likelihood and prior/posterior range.

Figure Number

book1 - 4.10

Figures

gist

Issue

#683

Steps

  • Updated the code following the PEP 8 guidelines.
  • Replaced numpy with jax.numpy following the CONTRIBUTING.md guidelines.
  • Using exp -> sum -> logpmf instead of prod -> pmf to avoid numerical underflow.

Checklist:

  • Performed a self-review of the code
  • Tested on Google Colab.

Potential problems/Important remarks

I have modified the colors and line styles to make plots visually separable when they superimpose. Please let me know if this is violating rules for using specific colors and styles for likelihood, prior and posterior.

@murphyk murphyk merged commit 79fecd5 into probml:master Mar 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants