Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added JAX GAN demo in Colab #685

Closed
wants to merge 3 commits into from
Closed

Added JAX GAN demo in Colab #685

wants to merge 3 commits into from

Conversation

susnato
Copy link

@susnato susnato commented Mar 10, 2022 •
edited
Loading

Description

Added JAX GAN demo in Colab

Issue

#675

Checklist:

  • [✅] Performed a self-review of the code
  • [✅] Tested on Google Colab.

@susnato
Copy link
Author

susnato commented Mar 10, 2022

Can you please review my code? @mjsML @murphyk

@mjsML mjsML self-requested a review March 11, 2022 18:28
@mjsML
Copy link
Member

mjsML commented Mar 11, 2022

Hi @susnato ,
Thank you for the PR, it's not viewable via GitHub for us.
Can I ask you to please create a new PR, convert this into .py for code and a scratch external colab to test it with (shared publicly).
Thanks

@susnato
Copy link
Author

susnato commented Mar 11, 2022 •
edited
Loading

Hi @mjsML
I will do it as soon as possible btw till then you can view it here , https://github.com/susnato/pyprobml/blob/master/JAX%20GAN%20demo%20in%20Colab.ipynb
It's in my forked repository.

@susnato
Copy link
Author

susnato commented Mar 12, 2022

@mjsML I am closing this PR then and opening another one.

@susnato susnato closed this Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjsML mjsML Awaiting requested review from mjsML

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@susnato @mjsML