-
-
Notifications
You must be signed in to change notification settings - Fork 37
first pass at saving history out to file on exit #28
Conversation
Thanks for providing this implementation. What I would change tho is this: Instead of just enabling logs and have
etc. What do you think? :) |
defaults path to ./logs So with my two channels Im gettng The rtt channel is kinda getting lost in the back of the date. Also I cant seem to find the target.. And im stealing the name from the args, not sure thats the best place, presumably its being parsed somewhere else? |
Made channel more obvious magic_wand_STM32F407VGTx_2020-07-25T18:12:27.848447655-07:00_channel0.txt |
Feedback requested |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now :) Thanks for doing this and sorry it took so long!
bors r+ |
Build succeeded: |
feel free to bike shed