This repository has been archived by the owner on Jan 14, 2023. It is now read-only.
Allow RTT & GDB to run concurrently! #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tiwalun
suggested changes
Dec 4, 2020
| .as_deref() | ||
| .or_else(|| Some("localhost:1337")); | ||
| // This next unwrap will always resolve as the connection string is always Some(T). | ||
| log::info!( |
There was a problem hiding this comment.
What's the reason for this change? Is there a threading issue with the logging::println call?
There was a problem hiding this comment.
Yes, this writes into the RTTUI, messing with the entire layout, rendering RTT unusable :/ I have not fond a way to swallow the logs from the GDB thread yet :/
Currently the GDB server also emits a lot of warnings that maybe should be debug logs. We sould clean this up.
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 5, 2020
159: Allow RTT & GDB to run concurrently! r=Yatekii a=Yatekii Co-authored-by: Noah Hüsser <[email protected]> Co-authored-by: Noah Hüsser <[email protected]> Co-authored-by: Yatekii <[email protected]>
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
robyoung
added a commit
to robyoung/cargo-embed
that referenced
this pull request
Sep 10, 2021
Since probe-rs#159 it has been possible to use RTT and GDB at the same time.
bors bot
added a commit
that referenced
this pull request
Sep 10, 2021
259: Remove mutual exclusion comment on RTT / GDB r=Yatekii a=robyoung Since #159 it has been possible to use RTT and GDB at the same time. Co-authored-by: Rob Young <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.