-
Notifications
You must be signed in to change notification settings - Fork 48
JSON Objects communication #179
base: master
Are you sure you want to change the base?
Conversation
4cd9636
to
eaab46a
Compare
@smcgregor check host_pages_integration.js |
eaab46a
to
43ee020
Compare
@smcgregor Added other methods too. Only adding tests remaining now, for this and privly.js file. |
var evt = document.createEvent("Events"); | ||
evt.initEvent("IframeRemoveEvent", true, false); | ||
var element = document.createElement("privElement"); | ||
var frameId = window.name; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These functions are largely duplicated 3 times. Maybe one helper function that is called with three different params?
Are you still working on tests for this? |
@smcgregor I'll do the helper function part and yeah, I had started working on the unit tests. I'll add those too in the next 3-4 days. |
Cool. This will be a great feature to have :) |
43ee020
to
f3d951d
Compare
This is still marked as "Needs Work." Is there something I am waiting on at this point, or should I be reviewing this PR? |
@smcgregor Yes, just give me few more hours. I had got stuck at some silly place in integration testing and then have been a bit away due to academics. But, I'll add integration testing(it's almost done) and then leave you another message here to review it. |
@smcgregor Just review it once. Also, I have a query about integration testing file. As far as I've understood other such ruby and capybara files, they pseudo-act like users. Click on buttons, opens navigation and so on to check how the whole system works. |
I think you might be limited to unit testing until an app implements the API. |
I've added unit testing already. You can then review, I think.
|
I wrote a shared messaging library that @summerwish abstracted so each of the scripting contexts could message each other across Jetpack/Chrome/Safari. The library should make it easier to integrate these changes across all platforms. Sorry it has taken me so long to update you here. This has been noted in my email for 3 months. I think it would be best to test and merge this into develop once the context_messenger.js lands in develop. |
The sending of resize message works. Hosting page sends a resize JSON object with the details of the iframe and the height of the content of iframe.
privly.js
recieves it and processes on it.