Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support watch --ignore cli flag #97

Closed

Conversation

amirrezamahyari
Copy link

Closes #65

@@ -154,11 +167,10 @@ It has an unfortunate overlap with React's [TSX/JSX](https://www.typescriptlang.

### Does it do type-checking?

No, [esbuild does not support type checking](https://esbuild.github.io/faq/#:~:text=TypeScript%20type%20checking%20(just%20run%20tsc%20separately)).
No, [esbuild does not support type checking](<https://esbuild.github.io/faq/#:~:text=TypeScript%20type%20checking%20(just%20run%20tsc%20separately)>).
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vscode auto format caused of that, I'll revert unnecessary changes asap...

@privatenumber
Copy link
Owner

Thanks for the PR!

Can you:

  • Add a test to make sure this functionality works
  • Remove unrelated changes in README

@privatenumber
Copy link
Owner

🎉 This issue has been resolved in version 3.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to pass exclude flag to watch
2 participants